Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update GitHub actions #4720

Merged
merged 2 commits into from
Oct 29, 2023
Merged

Conversation

reneleonhardt
Copy link
Contributor

  • goreleaser/goreleaser-action 3 -> 5
  • actions/checkout 3 -> 4

Also bumped default tag for nightly.

Signed-off-by: Rene Leonhardt 65483435+reneleonhardt@users.noreply.github.com

@reneleonhardt reneleonhardt requested a review from a team as a code owner October 29, 2023 16:50
Copy link
Member

@bruth bruth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, we appreciate the contribution @reneleonhardt! A couple questions, but otherwise looks good.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wallyqs Looks like this workflow was explicitly disabled a month ago, so it appears safe to remove.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this file post-PR. Don't want to block this one.

@@ -0,0 +1,10 @@
version: 2
updates:
- package-ecosystem: "gomod"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependabot docs don't give much insight, but I am going to assume this does not attempt to automatically propose new Go versions, only the dependency updates?

Copy link
Contributor Author

@reneleonhardt reneleonhardt Oct 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know only dependencies and not a major golang upgrade... but even if such a PR would be created you wouldn't have to merge it 😉
I totally agree on the docs though, real life questions and examples would be helpful indeed 😅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sure and agreed 😄

@bruth bruth merged commit a923096 into nats-io:main Oct 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants